Usei apenas os meus conhecimentos, ainda estou aprendendo

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which causes lacking of landmark for a webpage

  ---

  • So fix it by replacing the <div class="content"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  ---

  HEADINGS ⚠️:

  ---

  • This solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  CSS 🎨:

  • let me explain, How you can easily center the component for better layout.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .content {
     margin: 0 auto;
     margin-top: 10vh;
  }
  

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Naiara Medeiros•30

  @naiaramdrsPosted over 1 year ago

  @0xAbdulKhalid thank you for helping!!

  0
• 

  Snow•100

  @LuanS0Posted over 1 year ago

  Olá, Naiara. Tudo bem?

  Recomendo que estude um pouco sobre HTML Semântico e sobre as tags que podem ser utilizadas para cada estruturação necessária do HTML, tais como: <main>, <article>, <aside>,<section>.

  Com isso, recomendaria que usasse, para esses casos em específico, os Grid Layouts ou os Flex Layouts, bem como o estudo dos min-height: 100vh.

  Se esse comentário lhe foi útil, siga-me para mais. Até mais...

  Marked as helpful

  0

  ---

  

  Naiara Medeiros•30

  @naiaramdrsPosted over 1 year ago

  @LuanS0 obrigada, ajudou bastante!!

  0