Submitted 2 months ago
Used some basic styling and flex properties to achieve the given task.
@Vaibhav-Kumar-K-R
Design comparison
SolutionDesign
Community feedback
- @mkborisPosted 2 months ago
Nice work @Vaibhav-Kumar-K-R, here are a few things to review
- All content should be wrapped within landmarks. Wrap a
main
tag around the .container. - To improve the semantic meaning of these social media links, you should use the
a
(anchor) tag instead of thebutton
tag. Thea
tag is used for navigation to other pages, while thebutton
tag is designed for interactive actions like submitting forms or for events like toggling content. Also, using an unordered listul
to group the social media links is a better approach for both semantics and accessibility. - It's best practice linking Google fonts directly in the HTML
head
section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times. - Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
- Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
1@Vaibhav-Kumar-K-RPosted 2 months ago@mkboris Sure thank you for the suggestions will definitely improve on it. Newbie in the field of fronted development!!
0 - All content should be wrapped within landmarks. Wrap a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord