Used Sass

Community feedback

• 

  Luis Delgado•365

  @luisdevworksPosted about 4 years ago

  Hello Fer,

  For being your first project, it is very good, I like it.

  About your code, I think you should use better names for the classes, it's just my opinion, I suggest you check the BEM Method, in my case, helped me a lot. The BEM Method is in most cases for bigger projects but as I say, helped me to understand better the context of organizing my code between HTML and CSS.

  I also noticed that the transition from mobile to desktop the background didn't change..

  So I checked your code and you can add this code to fix it

  @media only screen and (min-width: 769px) { //You can add this to change the background body { background-image: url(../images/bg-desktop.png); background-color: hsl(229, 57%, 11%); background-size: 100% 50%; background-position: bottom; background-repeat: no-repeat; }

  Keep doing good work!

  1
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Nice job for your first challenge, Fer Siqueiros!

  Like @luisdevworks mentioned, make sure the background changes between the desktop and mobile layouts, and you should be all good to go!

  Keep coding (and happy coding, too)!

  0