used only html and css

Community feedback

• 

  P

  Jessica•880

  @perezjprz19Posted almost 3 years ago

  Hey there! Overall you did a good job, but I have a few pointers:

  • you can add aria-hidden = true to any images that you feel are not important enough to have alt text.

  • I would advise against styling on Id's and generally reserve them functionality.

  • on a bigger project, or one that you're gonna be updating, it might be helpful to come up with more descriptive names. Someone, including your future self, looking at #s, #su ,#l might be scratching their head for some time trying what those are tied to. Not so much a concern for this project because it is so tiny, but larger ones..... well. They might give you a headache.

  • it doesn't seem like you added any hover effects to it. You can do that very easily by background-color: transparent; to your buttons on hover and the color attribute to update the text.

  • Also, using margin: auto for the left and right side of your container is causing it to touch the edges of my screen on my phone. My want to update those to something else.

  You can see my solution here:

  Marked as helpful

  1
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Good Job you made it look nearly perfect to the preview

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body like it should be your container

  -> For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc

  -> But use header tag only once in main heading element.

  -> Reduce padding from left and right

  Keep up the good work!

  Marked as helpful

  1