Used margin

Community feedback

• 

  P

  Stefan Vetsch•140

  @vstmPosted 3 months ago

  Congratulations on finishing that challenge, nicely done!

  I have looked at your code and I have found some things that I would recommend to improve your code:

  • You have applied margin-left and margin-right of 25px to almost all of your elements in your content-area. This can be done a bit easier by applying a single padding to your #menu element, this way you can define the spacing once in the parent element and you don't have to add it to your child elements
  • For the table at the end you could use the <table> HTML element. This makes aligning the content inside the table easier (but I have to admit that styling a table can also be tricky).
  • Instead of using absolute position of your #menu element you can add display: flex; justify-content: center to the body element to center the menu.

  I hope these pointers help you out a bit, don't hesitate to ask if you have any question about my feedback

  0