Design comparison
Solution retrospective
Hello, community! Any advice is appreciated!
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
Regarding your question,
Your were overcomplicating the solution. All you have to do is create both contents, the "rating one" and the "thank you" in your HTML code. Style them with CSS and "hide" the thank you content.
You will then use JS to get the rating, the user chose, and display the thank you content.
- Change
width
tomax-width
in your component’s container to make it responsive. You will also want to delete theheight
as it is unnecessary.
- The “icons/images” in this component serve no other purpose then to be decorative; They add no value. There
Alt Tag
should be left blank and have anaria-hidden=“true”
to hide them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The proper way to build this challenge is to create a
form
and inside of it, the “rating buttons” should be built using aninput radio
(wrap all of them inside afieldset
), since this will prevent additional buttons from being active at the same time, and it should have alabel
element attached to it for accessibility.
More Info:📚
MDN <fieldset>: The Field Set element
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
Marked as helpful1@ClaudiaRamirezDPosted about 2 years ago@vcarames I tried to improve it as per your comments but now I can't get the radio/label to stay focused or active...Thank you so much for your feedback!
0@VCaramesPosted about 2 years ago@ClaudiaRamirezD
I am glad that I was able to help you out!
This should help...
https://moderncss.dev/pure-css-custom-styled-radio-buttons/
Keep it up!
1 - Change
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord