@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
Regarding your questions,
Unless if you companies requires you to use them, - Stay away from using libraries until you fully grasp the fundamentals. That is the purpose of this challenges.
Everything you work on a new project, a new repository is require.
-
Move the background color to the Body Element so the it takes up the entire screen.
-
To center you content to your page, add the following to your Body Element:
body {
min-height: 100vh;
display: grid;
place-content: center;
}
-
The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.
-
This challenges requires the use of two images 🎑 for different breakpoints. The Picture Element will facilitate this.
Here is an example of how it works: EXAMPLE
Syntax:
<picture>
<source media="(min-width: )" srcset="">
<img src="" alt="">
</picture>
More Info:
https://www.w3schools.com/html/html_images_picture.asp
https://web.dev/learn/design/picture-element/
-
The only heading in this challenge is the name of the perfume, “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a Paragraph Element.
-
The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include span element with an sr-only text explaining that this is the old price.
-
Implement a Mobile First approach 📱 > 🖥
With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
@Fahadnawaz007
Posted
@vcarames Thanks for your feedback.