Design comparison
Solution retrospective
Hey! How do you like this one?Please leave a comment below and pls check the source code!
Community feedback
- @pikapikamartPosted almost 3 years ago
Hey, awesome work on this one. Desktop layout looks fine, just that they are bit wider than the design. The mobile state looks great but your breakpoint of 1300px is too early and too big for the whole mobile state to occupy since desktop layout could use more of those screen-time.
Sergio Herrera already gave a feedback on this one , just going to add some suggestions as well:
- For this, you can just only have a single landmark element, a
main
tag. The.card__wrapper
selector could use themain
tag and you can just remove theheader
andfooter
. Usually, when you are usingheader
andfooter
as sectioning and not landmark, they are used inside thearticle
from I what I use and currently know since they section the content of it. - Lastly, just adjusting the breakpoint:>
The site actually looks great and doesn't need that much refactor. Again, great job on this one.
Marked as helpful0 - For this, you can just only have a single landmark element, a
- @santi19999Posted almost 3 years ago
@OlafZiorko Hola! Muy limpio tu diseño y se adapta a los requisitos estipulados por el desafío.
Una cosa muy mínima que me di cuenta, que cuando traduces la página a español en el punto de interrupción de 1300px, el h1 crece de tal manera que empuja todo el contenido hacia abajo, lo que hace que se corte el párrafo que está debajo.
Lo inspeccioné y encontre una posible solución, en (.card__wrapper) aumenté el tamaño de la fila que contiene el h1 y el párrafo, luego disminuí la fila siguiente en el (grid-templates-rows), para que coincidan los tamaños de la tarjeta. O puedes combinarlo con el tamaño de la fuente del h1 también.
Espero que me hayas entendido. Saludos..
Marked as helpful0 - @OlafZiorkoPosted almost 3 years ago
Sé exactamente lo que está pasando, decidí hacer esto pensando que nadie aumentaría el tamaño de la fuente.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord