Used HTML, CSS and JAVASCRIPT

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted about 2 years ago

  Hi Daniel, first of all, great attempt at putting this together! This page isn't an easy one to put together, but I can see that you tried your best, so great job!

  About your question on naming conventions, I think that instead of giving you suggestions on which one to use, I'd suggest instead that you check out Kevin Powell's YouTube channel. He recently did a series where he built an FEM landing page, and I think watching how he works and writes his HTML and CSS might interest you. I've gotten a lot of ideas from Kevin, and while I may not do exactly what he does, it has been helpful to try things out and see what works. So I suggest that you watch him and then try things out yourself.

  I just got some quick feedback for you as I'm looking at your solution here:

  1. Your hero image is looking quite big at higher browser widths! I suggest using max-width for the hero image so that it won't continue stretching. You can try something like max-width: 30rem to start and then play around with the values.

  2. For the mobile nav, it's pretty trick to do a sidebar, but you can try using position: fixed for the task. You can check out the draft practice CodePen that I put together for this challenge, and see if that gives you some ideas on how to build one: https://codepen.io/elaineleung/pen/poLpzge

  Good luck, and hope this helps!

  Marked as helpful

  1
• 

  daniel•180

  @d2ni3lPosted about 2 years ago

  Thanks a lot this was really helpful

  0