used html and css

Community feedback

• 

  Gabriel Monsalve•320

  @Gabrieldev-web-coderPosted over 3 years ago

  Hi, maybe you use propities that don't support the browser, or only you do bad things.

  For the background try use viewport units, and use the semantic html, and saw you use a div for a container of an image, the container of an img is the <figure> tag, the space of text that doesn't a paragraph, you can use <span>

  Search and learn about BEM is a method to add the classes in html to be more readable, remember that others i'll read your code, and the name of your classes is some confuse.

  You used also position to align the text and other things, for layout, the better way is use flexbox or grid, only for the img of victor is a good idea use the position, and you write so many code to a simple card compose, try to do reusable classes and do more writing less as possible.

  Sounds hard but no one is born knowing, only stay practicing and studing and you will improve, have a nice day.

  Marked as helpful

  0