Used HTML and CSS to complete the QR code challanage.

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 9 months ago

  Hello @Nasifuad!

  Your solution looks great!

  I have a couple of suggestions (about semantic HTML) for improvement:

  📌 First: Use <main> to wrap the main content instead of <div>.

  Think of <div> and <span> in HTML like plain boxes or placeholders. They're handy for holding content, but they don't tell us anything about what's inside or what it's meant for on the webpage.

  📌 Second: Use <h1> for the main title instead of <div>.

  Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.
  • <h1> defines the most important heading.
  • <h6> defines the least important heading.
  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  0

  ---

  

  Nasif Fuad•170

  @NasifuadPosted 9 months ago

  @danielmrz-dev Thank you so much for correcting my mistakes and suggesting improvement. I am thankful and will try to maintain this suggestion .💕

  1
• 

  Yusuf K. Muhammad•570

  @kyusufmPosted 9 months ago

  Assalamualaikum Nasif,

  Congrats on finishing the challenge. here's some suggestion from me:

  • for the width in this case you shouldn't use wh or %. you may use exact pixels.
  • for the semantic html tag you should use main and remove the outer div. and there's some more regarding this html semantic tag. you can read it more Here at Semrush

  1

  ---

  

  Nasif Fuad•170

  @NasifuadPosted 9 months ago

  @kyusufm Walaikumussalam, Thank you, brother for suggesting. I will use a semantic HTML tag next, Inshallah.

  0