Used HTML and CSS, learned about flexbot and other things
Design comparison
Solution retrospective
How to get the exact value of the width and length of the given design. Any suggestion will be welcomed.
Community feedback
- @PhoenixDev22Posted almost 3 years ago
Hello @sirargill,
I have some suggestions regarding your solution:
-
The images don't need filled
alt
. They are decorative images, so alt attribute should be left intentionally blank. You can optionally addaria-hidden
orrole presentation
to ensure the images are always ignored by screen readers ANDavatar's one andimage-equilibrium.jpg
should not be empty and should be descriptive . Read more about decorative and informative images . -
You can simply use unordered list
<ul>
to wrapclass="side-align’ and in each list item would have
<img >and
<p> `. -
You don’t need
<hr >
, you can useborder-top
for theclass="side-align
. -
You can use more html semantic tags like
<figure> <figcaption >
for the avatar part. -
Add the hover effect on the image . (The eye image is missing)
Hopefully this feedback helps.
Marked as helpful0@sirargillPosted almost 3 years ago@PhoenixDev22 thank you for your kind suggestions, I will make sure to implement those.
0 -
- @sb101-beepPosted almost 3 years ago
Try styling .container with flexbox centering.
0 - @jhernarPosted almost 3 years ago
you can try giving a min-height of 100vh in the body section
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord