Used Grid to align all the cards and also learnt media queries.

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted over 2 years ago

  Hi Rohit, congrats on completing your first challenge on Frontend Mentor! Your components looks good and got both the desktop and mobile views. What you can now look into are the issues in your report. Since it's your first challenge, you may not be familiar with the accessibility issues, so I'll try to point out some of these for you:

  "Document should not have more than one banner landmark": When you use a header element, that should only be used once; that is usually used for storing the elements such as company logo, banners, and navs, and are not the main content of your page. It's also not necessary to use a header element, but if you do use it on your page, make sure it's only used once. I see that you've used it in each card as a sort of title tag. You should use divs for those instead.

  "Document should have one main landmark": For the main content of your website, enclose it in a main tag. In this case it would be all the cards.

  "All page content should be contained by landmarks": Instead of using just a div for your card elements, use a semantic tag such as article.

  That should fix most of the issues. Once again, welcome to Frontend Mentor, and keep coding!

  Marked as helpful

  0

  ---

  

  Rohit Deshpande•870

  @rohitd99Posted over 2 years ago

  @elaineleung Thank you for your feedback, I'll surely work on those points.

  1