Used Grid Layout to complete this project and Scss Preprocessor

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey, great work on this one. The layout is a bit bigger, but preferences right. The layout is good and the mobile state is fine as well.

  Though when resizing, scrollbar appearance at the bottom because the width of the container is bigger. Maybe adjusting some sizes on it or making the size responsive. You can make use of clamp() function here which is really great. A lot has been using vh as main unit, which I don't really recommend.

  For some minor details

  • Adding corner radius
  • Adding cursor:pointer to the button, so that it will feel more natural since it is an interactive element.
  • Sizes

  For the markup, I see that you only used p tags on the "Why us" section. Those are supposed to be list of things, why you should pick them. So, using ul and li will be really good in terms of semantic markup. Though it works just fine, but I encourage you to make use of it in other challenges or in here , if you were to change it.

  Overall, great job^

  1
• 

  harisz85•210

  @harisz85Posted over 3 years ago

  thanks a lot ! I will check it out

  0