Used flexbox and grid

Community feedback

• 

  Artur Harutyunyan•400

  @ArturHarutyunyan1Posted over 2 years ago

  try to improve your responsive design

  1

  ---

  

  SuperSet1607•310

  @mohit1607Posted over 2 years ago

  @ArturHarutyunyan yeah that also I forgot to mention.

  0
• 

  SuperSet1607•310

  @mohit1607Posted over 2 years ago

  Hi Gavin You got it almost perfect. I assume you are working with Laptop so, you from your side done well, you can use an extension called Perfect-pixel to imitate the design as same, @ApplePieGiraffe recommended it to me. And You can use font-size in "rems" instead of "px" followed by declaring a font-size percentage. Default font-size is 16 px so you alter set that and use it in "rems". Another minor things I noticed are html issues that You did'nt used heading in sections, I will not go into details but you can see your accessibility reports and improve them. I think for UI, you did a great job.

  1

  ---

  

  Gavin Lang•30

  @GavinLang9Posted over 2 years ago

  @mohit1607 thanks for the feedback! I just started learning front end web development this summer so I don't know all the best practices for certain things. I was wondering if there was any article or resource I could use to better understand how to use landmarks. I understand they are important in SEO but I don't fully grasp how I should be using them. Thank you!

  0

  

  SuperSet1607•310

  @mohit1607Posted over 2 years ago

  @GavinLang9 here is the link for global sizing in rems. This article on medium is great.

  0