Design comparison
Solution retrospective
Javascript was bit tricky any suggestions are always welcome.
Thank you
Community feedback
- @nosthrillzPosted about 3 years ago
three quick things
You didn't handle the case where the inputs had values, but are now empty (aka fill both inputs, then delete one of them)
Also, the Reset button should be disabled when conditions are not met so that you don't show 'NaN' and 'Infinity' at the end.
and last: if I just write a bill value, then click on a tip without filling in the "number of people" field, it automagically gets filled to 1. But the designs showed a "can't be zero" error.
A nice quality of life change should be to give yourself a default tip value of 0, so you can see the split bill without tip. UX-wise, it's one less click (not having to go to custom to write 0)
P.S. It seems that the inputs were also supposed to be type="number"
0@santhoshpsd2Posted about 3 years ago@nosthrillz Thank you for suggesting I have handled default values and input type is a number and i have disabled the arrows in input.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord