Skip to content
Submitted over 4 years ago

Used flex, media queries, and relative units and also css variables.

Kishore S•125
@kishoreio
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Easybank landing page
  • HTML
  • CSS
  • JS
3intermediate

Design comparison

SolutionDesign

Solution retrospective

I did my best to create the easy bank landing and also there is an issue that my content is over flowing even though i used overflow: hidden it's not working. Please help me with an answer and also I would like to hear feedback on my code. Thank you

Community feedback

  • Adarsh Pratap•5,515
    @adarshcodesPosted over 4 years ago

    Hi! @kishoreio, Good work on this challenge👍 to fix the overflowing problem make those two divs inside the section width: 50%; and height = 100%; to each and then try to add overflow: hidden; to the main image container.

    • Design: your design looks fine, the problem you know already of overflowing image.
    • Responsiveness: your responsive code is not working properly, and smaller devices the image you use for the article section becomes distorted(you can try object-fit: cover;).
    • Issues aroused: try to fix the HTML and Accessibility issues after fixing your design and responsive code problem. Happy coding🙂
    1
    Kishore S•125
    @kishoreioPosted over 4 years ago

    @adarshcodes Thank you for feedback and yeah i will the issues.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord