Submitted over 2 years ago
Used Flex Box and Josefin Sans font from Google Fonts
@Sudarsh1010
Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Sudarsh, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add
main
tag and wrap the card for Accessibility - remove all
margin
from.container
class because with flex they are superfluous - add
min-heigth: 100vh
to body because Flexbox aligns to the size of the parent container - reset, so remove all margin from body
Overall you did well :)
Hope this help and happy coding!
Marked as helpful1@Sudarsh1010Posted over 2 years ago@denielden YO! I appreciate your review and I'll work on it. Thank You Brother
1@Sudarsh1010Posted over 2 years ago@denielden I've done that and now I got what you were saying. Thanks again
1 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord