Melvin Aguilar 🧑🏻💻• 61,220
@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML 📄:
- The
langattribute is used to declare the language of the webpage. Add thelangattribute to the<html>tag with the valueen.
- The
viewportmeta tag is missing. theviewportmeta tag is used to control the layout of the page on mobile devices. Add theviewportmeta tag to the<head>tag:<meta name="viewport" content="width=device-width, initial-scale=1.0">
- You should not use inline-CSS because it is not a good practice. Instead, you should use an external stylesheet to style your page. By doing this, you will be able to have a better organization of your code and will be able to understand it better.
- Use the
<main>tag to wrap all the main content of the page instead of the<div>tag. With this semantic element you can improve the accessibility of your page.
- Since this component involves scanning the QR code, the image is not a decoration, so it must have an
altattribute. Thealtattribute should explain its purpose. e.g.QR code to frontendmentor.io
CSS 🎨:
- Instead of using pixels in font-size, use relative units like
emorrem. The font-size in absolute units like pixels does not scale with the user's browser settings. You can read more about this here 📘.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
0
marukashvili92• 10
@marukashvili92
Posted
@MelvinAguilar I'm a beginer, just started, so, any comment and any hits are really important for me. thank you so much. I think i manage to solve all the issues, so could you check it again please and tell me how is it now?
0
