Alexandra• 550
@Alexandra2888
Posted
Hi! Congrats for finishing challenge! Here are some things I think you can improve:
- use semantic HTML,
- choose better names for classes, especially BEM naming convention is very useful,
- make CSS reset: *, *::after, *::before {margin:0; padding:0; box-sizing: border-box;};
- convert px into relative units (em/rem). Px are used mainly when coding for magazines/newspapers and you need fix units,
- use shorthand properties eg for margin, padding,
- make variables in :root{} eg for colors,
- add in body tipoghraphy properties eg font-family, line-height etc,
- don't use inline styles, in a big project will cause you a lot of bugs because of specificity,
- add alt attribute for images, also check again src because svgs are not displayed. Happy coding!
0
