Used display flex to centre container both horizontally and vertically

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 10 months ago

  Hello @Sahadev18!

  Your solution looks great!

  I have a couple of suggestions (about semantic HTML) for improvement:

  📌 First: Use <main> to wrap the main content instead of <div>.

  Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.

  📌 Second: Use <h1> for the main title instead of <h3>.

  Unlike what most people think, it's not just about the size and weight of the text.

  • The <h1> to <h6> tags are used to define HTML headings.

  • <h1> defines the most important heading.

  • <h6> defines the least important heading.

  • Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  1

  ---

  

  Sahadev Bhaganagare•150

  @Sahadev18Posted 10 months ago

  @danielmrz-dev Oh I did not focus on that, I was only thinking about somehow replicating the design. Thank you so much for the detailed explanation, I'll consider following the HTML semantics in my future solutions.

  1
• 

  P

  Zakhar Polikarpov•260

  @ZPolikarpovPosted 10 months ago

  Hey, nice job on completing the challenge. As timodn pointed out using percentages does certainly help. Here are some techniques you can look up as well, that help with varying screen sizes:

  • Use clamp(...) for smooth transitions between values. There are some clamp generators online that help you find the correct values.
  • Use mediaqueries for different screen sizes @media only screen and (max-width: ...)
  • You can use functions like max(...) min(...) and minmax(...) to have a lowest or highest value that something should have.
  • Try to not use "magic numbers" where it's not necessary. Look for a way to have your numbers be relative to something. Usually you would use somehting like 100% values or 100vw or 100vh

  Tell me if you have any further questions. Making responsive sites might be quite challenging, so experimenting with these concepts will definitely add some tools to your repertoire. Good luck coding!

  Marked as helpful

  1

  ---

  

  Sahadev Bhaganagare•150

  @Sahadev18Posted 10 months ago

  @ZPolikarpov Thank you so much that was helpful

  1
• 

  timodn•240

  @TimmyOGHPosted 10 months ago

  Use percentages instead of fixed values like width: 100%;

  Marked as helpful

  1

  ---

  

  Sahadev Bhaganagare•150

  @Sahadev18Posted 10 months ago

  @timodn Thank you.

  1