Used custom CSS properties

Community feedback

• 

  Sachin•830

  @Sachin-MahatoPosted over 1 year ago

  Good job for finishing the challenge.

  As a front-end developer, your primary task is to transform the designer's visual concept into a functional website. The objective is to ensure that the final website closely resembles the original design. However, if there are noticeable differences between the website and the intended design, it's important to address this issue.Use the build-in frontend Mentor design comparison tool.

  ---

  This challenge consists of two parts: the mobile component and the desktop component. However, it appears that the mobile part has not been developed. It's important to address this issue and ensure that the challenge's mobile and desktop aspects are completed.

  ---

  1. Lack of semantic HTML:

  • Semantic HTML elements are missing.
  • The structure does not convey the meaning and purpose of different parts of the webpage.

  2. Usage of absolute units instead of relative units:

  • Absolute units like pixels (px) are used for defining lengths and sizes instead of relative units like percentages (%), em, or rem.
  • Relative units are more flexible and responsive across different screen sizes.

  ---

  3. It seems that you are not currently using an external stylesheet for your web page. I would recommend utilizing an external style.css file for your styles. This approach offers several benefits such as code reusability, ease of maintenance, browser caching, and improved performance

  ---

  I hope you find this helpful and happy coding.

  0