Used CSS grid again, mobile first.

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  Hi, Chukwudobe! 👋

  Congratulations on finishing this challenge! 🎉

  Here are some suggestions for improvements.

  • Always wrap text content with a meaningful element like a paragraph element whenever possible.
  • I recommend reading the "How-to: Accessible heading structure - The A11Y Project" article to learn how to use headings correctly.
  • Always specify the type of the button. It will prevent the button from behaving unexpectedly (like submitting).
  • Code your font size in rem, not pixels. This means the text size will be responsive if people want to adjust the size.
  • Prefer unitless numbers for line-height values to avoid unexpected results. The MDN documentation of line-height explains it well.👍

  I have two recommended videos. The first one is telling how hard HTML is (HTML is not easy). The second one is talking about HTML and modern CSS.

  • Manuel Matuzović - Lost in Translation - YouTube
  • Andy Bell – Be the browser’s mentor, not its micromanager - YouTube

  I hope this helps! Happy coding!

  Marked as helpful

  0

  ---

  

  Chukwudobe Micah Chinedu•700

  @chukwudobe-MicahPosted about 2 years ago

  @vanzasetia thank you, I will do all this.

  1
• 

  ugbe kelechi adie•140

  @ugbeadiePosted about 2 years ago

  Hi Chukwudobe, congrats on completing your project.

  From a visual perspective, I noticed after viewing your site that the 'sign up' text was difficult to see. I suggest using a lighter color for the text(maybe white) to go with the color scheme.

  Hope this helps. Happy Coding.

  0

  ---

  

  Chukwudobe Micah Chinedu•700

  @chukwudobe-MicahPosted about 2 years ago

  @ugbeadie okay then, thank you. I'll change this too when I get on my laptop. Thanks for your reviews.

  0