Design comparison
Solution retrospective
I was able to use CSS variables to store the most used colors.
What challenges did you encounter, and how did you overcome them?No challenges were encountered.
What specific areas of your project would you like help with?Any suggestions on how to improve are welcome.
Community feedback
- @R3ygoskiPosted 7 months ago
Hello @Ephy-kimotho, good job, your project is very good.
I want to give you some tips, first about your HTML. I highly recommend to use svg's with
<img/>
tag, because it's make your code more clean. And about Semantic, this part<section class="text">
could be an<article>
, and your<div class="container">
it's more apropriate be used as<main>
tag, because it's the main content of the page. Here a link about semantic HTML, W3School - Semantic HTML.And another tip, now focused on CSS, I highly recommend to use rem units in
font-size
, because it's a relative unit, it can adapt to user font size configuration, and it's help a lot in accessibility.And again, congrats for conclude your project, it's very good. If something I said was unclear, please, comment below and I will try to help.
1@Ephy-kimothoPosted 7 months ago@R3ygoski Thank you for the feedback, I will try to implement semantic HTML in my next projects.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord