used CSS and HTML, made my own QR-Code

Community feedback

• 

  Anwar Mestycer•420

  @AnwarMestycerPosted 7 months ago

  Hi, you did well. You are a few steps away from matching the design.

  • Change the body background to hsl(220, 15%, 55%).
  • Add justify-content:center; align-items: center; to your body selector in the CSS file to center your qr-component in the middle of the screen horizontally and vertically.
  • Remove the background color from the card selector so it remains white by default.
  • Set the border radius to 5% to match the design.
  • I can't see why divide the paragraph on two p tags, put the inside one p tag
  • Instead of using the <center> tag add text-align: center; to the card selector in css file, same the for the h2 tag.

  This is just the beginning of your awesome journey as a front-end developer Keep up the good work.

  I hope this was helpful, and if you need any help, don't hesitate to contact me here.

  1
• 

  Ryan King•40

  @MsftKingPosted 7 months ago

  It looks very good although, don't have much responsivity when changing the screen size it stays in the same spot. I feel it would be more accessible if it shifted with the change in the screen. I used a flex box and div for the images with respective padding and margins that remain when the screen sizes decrease. Hopefully this tip helps you!

  0