@visualdenniss
Posted
Good job on completing the challenge successfully! Your solution looks great overall. Especially on desktop.
I noticed in mobile view, the column have very high height. You could reduce that by using max-height: some-pixel-value( e.g. 600px), but also adjust the space between elements. It looks like you are using 40% margin for the button, i'd say 40% causes issues, as it is in relation to the containers height, so the bigger the container is margin will be higher, but this is not what you want in this case. So you can replace that with a fixed value like 40px or some 'em' etc. to make it consistent.
Hope you find this feedback helpful!
Marked as helpful
@visualdenniss never ever set max height or height on elements containing text. All that does is introduce potential for breakage when users change their settings or editors adjust the content. It’s really important to keep solutions flexible.
@visualdenniss
Posted
@grace-snow Ok, thanks for the reminder and the tip. Will keep that in mind!