Used basic HTML, CSS, and JS

Community feedback

• 

  Abhik•4,840

  @abhik-bPosted almost 4 years ago

  Hi Zach, Your solution is very responsive and seems perfect 🔥🔥

  Actually why the text is becoming black after a valid email entry is this code block:

  else if (inputValue && inputValue.includes('@')) {
          errorText.innerText = '.';
          errorText.style.color = 'black';
      }
  

  In the above code you set the error's (** inline style** ) text color to black and inline-style is given priority when a css property has different values in css files.

  However , when you enter a invalid email after that valid entry any of the below code blocks are run :

  if(!inputValue){
          errorText.innerText = 'Oops! Please add your email';
          errorText.classList.add('textContainer__error--visible');
      }
      else if (!(inputValue.includes('@')) && inputValue){
          errorText.innerText = 'Oops! Please check your email';
          errorText.classList.add('textContainer__error--visible');
      }
  

  In the above code block you change the text of the error but its color is set to black only (inline-styles), you need to add something like errorText.style.color = 'red' to make it have red color again.

  Hope this is useful to you, and keep on contributing this amazing solutions 🚀

  2

  ---

  

  Zach Kyman•220

  @zky63Posted almost 4 years ago

  @abhik-b Thanks for the in-depth comment. I don't know why I tried to over-complicate it by adding classList to the JS. But I used what you said and it worked perfectly.

  1

  

  Abhik•4,840

  @abhik-bPosted almost 4 years ago

  @zky63 Hey Zach, I again took a look at your solution and it works perfectly now , glad my feedback was useful to you😇

  1