Used Absolute positioning and relative positioning for designing this

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted about 3 years ago

  Hey,

  Here's a few things you could improve on:

  1. You should add your own readme file to the project (the one you uploaded is Frontend Mentor's readme to help you complete the challenge).

  2. More semantic markup: your content could be contained by main element instead of a plain div. Headings also have a semantic meaning (for styling there's CSS) and should start from h1. For your buttons, it's not really considered good practice to use divs (or if you do, more markup is needed so screen readers understand what element it might be). Use button or a.

  3. Your background image/color should be added to the body rather than a container so it covers the whole screen.

  4. You should consider using relative units, like em, rem, etc instead of setting everything in pixels.

  5. Your breakpoints seem to be broken, your site isn't really responsive.

  6. Hover states are missing.

  It's a big list, so sorry for that but hopefully it helps a bit :)

  Marked as helpful

  0

  ---

  

  Sarat Chandra K S K•40

  @Sarat-DevPosted over 2 years ago

  @FluffyKas Thanks! atleast someone gave a feedback

  0