use react for filtering list and react router dom also design in css

Community feedback

• 

  Felipe Stefani•330

  @felipestefaniPosted over 1 year ago

  Despite the css gap, the project get very nice!

  All the logic seems to be perfect and the classes are bind dynamically, as I could see.

  I don’t know if you know tailwind or bootstrap, but it helps a lot with the style.

  I’kk let the links here to check it out: tailwind bootstrap

  In my projects I’m coding all css as well, but now it’s my focus. If the idea is to code the project, this tools helps a lot!

  Great job! I liked a lot 😉

  Marked as helpful

  0

  ---

  

  oishi•150

  @sumyta12Posted over 1 year ago

  @felipestefani thanks for your feedback yes i know bootstrap but in responsiveness i face difficulties in css i will make it more better . Again thanks for feedback😊😊

  1

  

  Felipe Stefani•330

  @felipestefaniPosted over 1 year ago

  @sumyta12 I'm focusing my efforts on learn css now too.

  It looks easy at first, but there are many things and possibilities to achieve the same goal. I'm having some trouble with responsiveness some times, but we just learn and get better making more and more!

  If you need some help, and of course I can, just contact me. If I have some problem to share, I look for you too ☺️ This way we learn together!!

  Marked as helpful

  1
• 

  Fazza Razaq Amiarso•2,340

  @fazzaamiarsoPosted over 1 year ago

  Hi @sumyta12! Great job on your project!

  I have some quick suggestion for you:

  • It's better to set initial state in useState Initialization, rather than in useEffect.

  const [joblist, setJoblisting] = useState([...Joblistingdata]); // initialize state here ✅
  

  • In your urlParams useEffect, you can refactor it like this:

    for (const [key, searchValue] of Object.entries(displaySearch)) {
        if (Array.isArray(searchValue)) {
          searchValue.forEach((value) => {
            urlParams.append(key, value);
          });
        } else {
          urlParams.set(key, searchValue);
        }
      }
  

  I hope it helps! Cheers!

  Marked as helpful

  0

  ---

  

  oishi•150

  @sumyta12Posted over 1 year ago

  @fazzaamiarso ohhoo , yes i can also do that way also. thanks for your suggestions😅

  0