Use Html and pure Css clearly handling the bem methodology :)

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted about 3 years ago

  Hey, great work on this. Layout seems fine but you are missing the background image, the wave image one. Perhaps you forgot to add it?

  Some suggestions would be:

  • If you inspect your website in dev tools at the bottom, you can see that your layout is being squished. This is caused by the height: 100vh on your main tag. If you set an element to have height: 100vh it might look fine to your monitor/screen, but if you scale down your browser's height, you can see the distortions. This is because using height: 100vh only occupies the current viewport's height. Removing this will be really good or you can set a max-height: 100vh instead of height: 100vh. Also on your body tag, do not set the font-size: 2vh , do not use scaling units on font-sizes unless you are using a clamp function. Use rem units
  • Good choice on using article!
  • your page lacks h1 element, you can use the h1 to wrap the order summary text instead of using h2 on it.
  • Your proceed to payment and cancel order html element is not suited. You used div which is not accessible at all. You can use either a tag or button on those two elements. If you think that the functionality links you up in another page, use a tag. If you think that clicking those element pops up a modal or some sort, use button.
  • Also you don't have to position: absolute the attribution.

  Aside from those, good job.

  Marked as helpful

  1
• 

  Sergio Pinzón•85

  @sergiopin22Posted about 3 years ago

  Hey really, thank you very much, what a good feedback you have given me, I really appreciate you, I hope to continue practicing I am from Colombia and I have to translate your opinion lol

  Greetings what a good level I see that you drive :)

  0
• 

  Yunus Alif•150

  @frontendnusPosted about 3 years ago

  I only have a little bit feedback. I think you overuse flexbox there where we can still do without flexbox. But your project looks good for me

  0