Design comparison
Community feedback
- @atif-devPosted almost 2 years ago
Hi Yingchu Liao, congrats🎉 on completing the challenge. Better take care about following points. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
<body> <main> ---your code here---- </main> <footer> </footer> </body>
(why
main
matters? Read here)- For proper centering the container(whole card) vertically and horizontally you can use code as:
body { min-height: 100vh; display: grid; place-content: center; }
Or you can learn centering from here.
- When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.
If the Feedback is Helpful for you, Don't Forget to upvote and click on MARKED AS HELPFUL 😇......That Will Make My Day😇
Marked as helpful0@ellenliao95Posted almost 2 years ago@atif-dev
Hi, Atif-Iqbal
Thank you for your prompt response and for informing me about the new property. it has been very helpful and informative.
However, I'm having difficulty understanding the last part regarding Github. I have been unable to locate the "About Section" on my Github account. Would you kindly provide me with more information about how to find it? or setting it?
thank you for your help and have a great day!
1@atif-devPosted almost 2 years ago@ellenliao95 A short video will be much better than just text....open this link Good Friend, watch video and find out😇.
0@ellenliao95Posted almost 2 years ago@atif-dev
OMG! This is so good!! I know how can I do now!! thank you so much!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord