use flex overlay box-shadow ......

Community feedback

• 

  Muhammadh•1,140

  @Mr-jawPosted almost 2 years ago

  Hello there 👋

  Congratulations on completing the challenge

  HTML

  • replace <div class="nft-card"> with the <main> tag to fix accessibility issues

  • avoid using hyphens in the alt attribute of the <img> tag since it should be humanly readable text. You are welcome to use space when it comes it separating words.

  • Use <h1> instead of <h2> in <h2>Equilibrium #3429</h2> since it the main text of the component

  • avoid using the <p> tag to display short text, you can rather use <em>, <strong>, or <small> tags. It will improve accessibility.

  CSS

  Your CSS looks okay, it would be better if you used relative units for width as well. Also, you have followed some good practices of using CSS custom variables.

  Above all, your submission looks nice. 🔥👍

  I hope this was useful 😊

  HAPPY CODING

  Marked as helpful

  0

  ---

  

  Jamel Issaoui•100

  @jamel123aPosted almost 2 years ago

  @Mr-jaw thank you so much

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="des"> with the main tag and <h2> with <h1> to fix the accessibility issues. click here for more on web-accessibility and semantic html

  Reduce the spread and blur radius values of the box shadow.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0