@Mr-jaw
Posted
Hello there 👋
Congratulations on completing the challenge
HTML
-
replace
<div class="nft-card">
with the<main>
tag to fix accessibility issues -
avoid using hyphens in the
alt
attribute of the<img>
tag since it should be humanly readable text. You are welcome to usespace
when it comes it separating words. -
Use
<h1>
instead of<h2>
in<h2>Equilibrium #3429</h2>
since it the main text of the component -
avoid using the
<p>
tag to display short text, you can rather use<em>
,<strong>
, or<small>
tags. It will improve accessibility.
CSS
Your CSS looks okay, it would be better if you used relative units for width
as well. Also, you have followed some good practices of using CSS custom variables.
Above all, your submission looks nice. 🔥👍
I hope this was useful 😊
HAPPY CODING
Marked as helpful
@jamel123a
Posted
@Mr-jaw thank you so much