Use Flex Box & Position

Community feedback

• 

  Web Wizard•5,690

  @rsrclabPosted almost 3 years ago

  Hi, ~

  Congratulate on your solution to the challenge on FM platform. I have studied your work carefully and learned a lot from it. Especially I like the image overlay effect on your project. Especially I like BEM structuring on your project.

  Here are some of the tips I like to provide.

  • On smaller devices, card goes over screen, and I think max-width: 100% can solve this issue.
  • Please try BEM for naming element classes. It will help you a lot on bigger projects.

  https://www.frontendmentor.io/solutions/my-first-solution-on-chanllenge-V-4IzAivH

  Here is my solution to this challenge, and if it can help you even a bit, it would be happy to me.

  Cheers ~

  Marked as helpful

  2

  ---

  

  Abdulrahman•60

  @Abdulrahman14SalahPosted almost 3 years ago

  @tymren608 Hi Bro , Thank You For Following , Okay I'll Change It

  0
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Good Job you made it look nearly perfect to the preview

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body like it should be your container

  -> For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc

  -> But use header tag only once in main heading element.

  -> Always use h1 first and then h2, h3 and so on

  Keep up the good work!

  Marked as helpful

  1

  ---

  

  Abdulrahman•60

  @Abdulrahman14SalahPosted almost 3 years ago

  @Crazimonk Thank you Bro , I'm really Thankful For This Tips

  1