Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

use css grid and flex properties

prakhar 130

@Prakhar-99

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


how i make svg img fit in my content at all screen size

Community feedback

@rehberbey

Posted

I checked your codes and I noticed that you have backgrounded something using svg in html. This is bad practice, both from an accessibility standpoint and from a caching standpoint. My advice to you is to use the background property. Other than that, I found your work pretty good. Congratulations. 🎊

Marked as helpful

1

prakhar 130

@Prakhar-99

Posted

@rehberbey yes brother I also face many problem on using svg because i don't able to make it fit in full background. but this challenge give it in asset can it's ok to make it by myself by background property. But your feedback is valuable for me thanks for give my effort your time.

1

@rehberbey

Posted

@Prakhar-99 Sorry, I use Google translate as my native language is not English. This is what I need to understand from your sentence; You can do it with the background feature, but you want to put SVG over HTML. If I understand correctly; I suggest you read the accessibility topic on mozilla's site. And here I leave a link about background: https://developer.mozilla.org/en-US/docs/Learn/Accessibility/HTML#:~:text=One%20thing%20to,CSS%20background%20images.

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord