Design comparison
Solution retrospective
I would love to know your feedback on how I can optimize it. If you have any suggestions do mention them in the comments. I would love to hear from you.
Community feedback
- @tensor0210Posted almost 4 years ago
Hey! Great job Code really documented well Few Code Improvements which will help when collaborating with others:
1- File name: main.css and script.js instead of index.css and index.css 2- Use const for all Document objects(apart from sliders) 3-Avoid var 4-Don't use console.log in the production 5-DRY - Don't repeat yourself Eg pricing.innerHTML = "$" + 8 pageviews.innerHTML = 10+"K" convert this into a function 6-Make use of more string Literals
Again great Job mate! Learnt a lot of CSS from your code base. Cheers :D!
1@asifkhan0410Posted almost 4 years agoThank's mate! for a detailed answer will improve on these.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord