Submitted about 4 years ago

URL shortening

Walid Ben Abdessalem• 835

@bawalid

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

URL shortening API landing page

HTML
CSS
JS
API

3intermediate

View challenge

Design comparison

SolutionDesign

Community feedback

Paul Ibeabuchi• 165

@NARUDESIGNS

Posted about 4 years ago

Hello Ben, nice solution, but I think I found some little problems in ur solution...

Everytime I click on the "Shorten It!" button, "Please add a link" is being printed on the screen... I clicked 7 times and it printed "please add a link" 7 times.

Also I think u should add a loader to indicate to the user that the request is processing ✌️

Walid Ben Abdessalem• 835

@bawalid

Posted about 4 years ago

@NARUDESIGNS Hey, thank you for passing by my code and figure out these errors. I'v fixed the "Please add a link" error. for the url to work it should be in this format "www.website.domaine", I added the https:// in js to the url to work.

Paul Ibeabuchi• 165

@NARUDESIGNS

Posted about 4 years ago

Hi, I think making the url work with "www.site.domain" may tamper the overall usability of the application. Most people like to copy the link directly from their browser and paste it to Shorten it and this copied link doesn't often come with "www", it's usually "https://website.domain". Therefore you don't need to include "https://" in js since it most likely would be included in the link the user wants to Shorten.

Paul Ibeabuchi• 165

@NARUDESIGNS

Posted about 4 years ago

Also the API never shortens the link, instead It prints out "please add a link" too

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord