URL shortening

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  ---

  • This solution generates accessibility error reports due to non-semantic markup

  ---

  • So fix it by wrapping the whole content the with semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  • This solution also had generated accessibility error reports due to skipping heading levels

  ---

  • We want to avoid skipping heading levels, make sure to start with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that our document has a clear and consistent hierarchy. Read more 📚

  ---

  • Because skipping heading levels is a poor practice from the perspective of information design, whether we are talking about web pages, books, journal articles, or about anything else. You can not only confuse screen readers but all readers when you don't follow a consistent, logical pattern with your heading structure.

  ---

  CSS 🎨:

  • Setting the font-size to 62.5% can cause compatibility issues with third-party libraries or plugins.

  ---

  • Then the visitor want to increase the font size every time they visit your site and decrease it again when they leave it

  ---

  • It will render your site unreadable for the first visit which means you'll loose 99% of all visitors.

    • 1. The 62.5% Solution? By Tracy Rotton

    • 2. Should I change the default HTML font-size to 62.5%?. by Grace Snow

  ---

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1