URL shortening API landing page - made with: React, scss, Vite
Design comparison
Solution retrospective
Hello Frontend community,
this one I did with React and Scss for the first time, but this mini-app should work as intended. If you spot anything weird, feedback is always appreciated!
Community feedback
- @NikolaD93Posted almost 2 years ago
Hello there! 👋
Congrats for completing the challenge! 🙌
I have 2 suggestions for you:
1.Make sure to write some description on all of your images in the alt attribute. 👇
https://www.w3schools.com/tags/att_img_alt.asp
2.Put all nav-links or footer-links in an unordered list - <ul></ul> tag, then in list - <li></li> tags, which then have <a></a> tags. 👇
https://www.w3schools.com/html/html_lists_unordered.asp
Hope this was helpful for you!
Happy holidays! 🎉✌
Marked as helpful0@GoranK89Posted almost 2 years ago@Nikola1232456 Thank you for the advice. Thank you and happy holidays also.
1 - @ZeyadMohamed1805Posted almost 2 years ago
Awesome work right here bro! I have some tips for your design:
- Try to add some left & right padding to your header and sections. That way when the screen shrinks, there will be some space between the elements and the screen, which will make it look not as compressed.
- I recommend setting the max-width of your media query to more like 1000px. Otherwise, the elements on your web page will not have enough space, which results in paragraphs overflowing and images not full appear.
Other than that, your design is absolutely amazing!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord