Url shortening - React, Typescript, Zod, Zustand

Community feedback

• 

  BrunoMoleta•700

  @brunomoletaPosted 5 months ago

  (Please check the Pull Request at your Git hub repo)

  Hello Eduardo, how have you been?

  I took some time to review your project.

  The most important advice for you is to make the React components shorter. You can also divide the CSS into multiple smaller files as it gets easier to read and edit.

  The HTML structure shall be

  <header>...</header>
  <main>...</main>
  <footer>...</footer>
  

  But the code provided had a main with only a few lines and many elements 'loose' directly at the body.

  Also, at the header I changed it to two separate nav tags instead of one large one.:

  <header className="header">
        <div className="header__container">
          <div className="header__navbar">
            <img src="/logo.svg" alt="logo" />
            <MenuButton />
            <Nav />
            <NavForm />
          </div>
        </div>
      </header>
  

  I also created a data.ts file where all data can be stored, where the marketing team would fill, in a real scenario, and the components can stay the same wherever the change, please see MenuMobile.tsx.

  Adjusting the components broke part of the layout, and changes in the css would be necessary.

  Congrats on the project, and keep up the effort.

  Best regards from 🇧🇷

  Marked as helpful

  0