Design comparison
Solution retrospective
I have a few issues with this one that I would welcome feedback on, mainly related to images.
-
The orange icons look distorted on Chrome and Firefox, but not Safari. I have tried to get the aspect ratios working, but I can't manage it and maintain the overall icons at a consistent size. Any advice on how to approach this would be appreciated as I've stumbled on this issue a couple of times.
-
I should have adjusted the 'hero' image so that it aligned flush with the viewport at smaller viewports, and the opposite for the the second image (flush against the opposite side). I tried adjusting using a relative positioning, but it didn't maintain the margin on the side that wasn't flushed, and a few other random things that didn't work. Any ideas?
Thanks for any other comments and feedback. I am loving SCSS more with every challenge now and while I'm really glad to have waited a good while before trying it out it is really speeding up my work now.
Community feedback
- @ApplePieGiraffePosted over 3 years ago
Hey, Dave! š
Just wanted to drop in to say great job on this challenge! š I don't really have much to suggest here since everything seems pretty good to me (and I believe you got those issues with the images sorted out)! š
Sass really is a lot fun and it's nice to hear you're enjoying it more and more! š
Keep coding (and happy coding, too)! š
1@dwhensonPosted over 3 years ago@ApplePieGiraffe Thanks as always for taking a look! Great that you didn't have much to say!! Cheers
0 - @ChamuMutezvaPosted over 3 years ago
Hi. You are on a roll Dave. Well done. I could not see the issue with icons as they are not showing in my browser. I have done the same project and what i did was to wrap the icons in a div and then controlled the div's dimensions. You can see my solution on here The footer content is not center aligned in the center as per design but other than that , this is good Happy coding
1@dwhensonPosted over 3 years ago@ChamuMutezva thanks. I love your solution and how you approached these aspects of the challenge. I think I can see a plan for solving these issues now! Cheers!!
1@dwhensonPosted over 3 years ago@ChamuMutezva Thanks again - I used your approach for the icons and image adjustments and I think that sorted it. Much appreciated.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord