Typemaster Pre-Launch Landing Page Usnig HTML & CSS

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  • use a more suitable title than <title>Document</title>
  • while the below works to display the images , it is not among the best practices. It is also expensive to the user and can slow down the loading of the page as each and every image has to be downloaded. Using responsive image techniques allows only the required image for a device to be downloaded, the methods includes srcset and picture element

  <img class="desktop" src="images/desktop/image-keyboard.jpg" alt="">
   <img src="images/tablet/image-keyboard.jpg" alt="" class="tablet">
     <img class="mobile" src="images/mobile/image-keyboard.jpg" alt="">
  // method not recommended
  

  • the site is responsive but you need to revise your css. some media queries are not necessary . well done

  Marked as helpful

  1
• 

  Muhammad Ahmad Hassan•340

  @hassanahmadpPosted over 3 years ago

  Hello Fadi,

  Hope you are alright... You did a great job, however, You lacked at some points. Which near to me is due to a lack of theoretical knowledge... I recommend you to have a strong search on the following concepts because these are very crucial:

  1. Z-index

  2. Z-index scoping ( This is hard to find but solves a lot of problems )

  3. Flex-box

  4. Grid

     Moreover, you have used accessive media queries which is not an efficient way and will take a lot of your time. I recommend following along with some youtube channels and see how they write code... What I can see is you are trying to run before trying to walk, and in this way, you are getting a hard time running...

     I recommend slowing down a bit and try to understand the crucial concepts of HTML and CSS...

     I hope this helps, Happy Coding!

  0