Typemaster pre-launch landing page

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 3 years ago

  Hey Mikolaj, nice work on this challenge! How did you get on working with the design file? Your solution looks good and compares well to the design, so great job on that! 👍

  I've got a couple of small pieces of feedback:

  • You're not using any img elements and are instead only using background-image in your CSS. I'd love to hear your rationale around that if you're happy to explain. I'd say that the logo and the keyboard images add context to the content and therefore, should be img elements with the appropriate alt text to describe the images for screen reader users. At the moment, none of the imagery would be read out to screen reader users. The icons near the bottom are fine to be omitted for screen reader users as they're decorative, but I'd still probably use img elements with blank alt attributes.
  • I'd also recommend avoiding chaining your selectors unnecessarily. For example, this selector .general .info button.second-preorder could be changed to this .second-preorder. Keeping the specificity of your selectors as low as possible will help you write more maintainable CSS. Especially in larger projects!

  I hope that helps. Let me know if you have any questions! 🙂

  2

  ---

  

  P

  Nicholas•235

  @fytrwPosted over 3 years ago

  @mattstuddert Thanks a lot for your feedback!

  • Sure, I should use img tags instead of background-image in this elements. I'm still learning and for now accessible isn't the most important for me.

  • Thanks, I haven't known about that, I will change it in future projects. Maybe I should use sass.

  Thanks for your time and your comment.

  0