Typemaster prelaunch HTML/SCSS

Community feedback

• 

  P

  The Burrito Doggie•1,260

  @BurritoDoggiePosted over 3 years ago

  Hello itsagift!

  You did a good job with keeping every thing close to the original! I love it when people add extra effects. I love your effects when you press the 'pre-order now' button. I don't even know how to do that. And you also did wonderful with the 'mobile solution padding'. I'm actually giving feedback on a small screen.

  Keep Coding!

                                 (•‿•)
  

  Marked as helpful

  1
• 

  eagermonument81•210

  @ixtkPosted over 3 years ago

  • from about 1040px when scaling, the 2 images are stretching and losing aspect ratio. Consider using object-fit: cover
  • children in .bottom have no margin next to each other. The texts almost touch each other. Use row-gap or column-gap for space in between children if your layout is either flex or grid
  • you could have just used padding on img for those icons and not nest them in div
  • you could have displayed .bottom as grid the whole time. There's no need to display it as flex, just have either 2 or 1 column depending on the size of the screen.
  • the images that are snapped to the side aren't supposed to have border-radius the side they're touching browser edge on

  The way I did the snapping part is gave section container fixed padding, like 24px and then used margin-[left/right]: -24px on the image.

  Don't forget to check the report

  Marked as helpful

  0

  ---

  

  Chase Reynolds•130

  @itsagiftPosted over 3 years ago

  @ixtk Very helpful thanks! The image scaling was the hardest part for me. When I used object fit: cover it would look absolutely wrong at some displays. I have to go back and check that.

  0