Rio Cantre• 9,690
@RioCantre
Posted
Hello there! Awesome work with this challenge. Looking at your solution, I think you should know the following as well…
- There are possibilities to add more semantic tags. For instance, this line
<div class="header__grid--right">
can be wrap withfigure
tag and this one<div class="main__title--text">
withsection
. But everything is looking great and well used of most common semantic tags. - The code is clean and well structured.
- Try viewing around
1116px
viewport, the images in the.main__imgs
rule set havejustify-content: space-between;
, change it withjustify-content: flex-start;
. Since the main header image is transitioning from left to right. - Well use of Sass in styling, specially the compositions
- I think you could try adjusting the Flexbox in
696px
viewport for the.main__title--text
rule set and set themain ul
rule set withtext-align: center;
orjustify-content:center;
. If your using mobile first, try adding another breakpoint or increase the size - The details of the design are well implemented based on the original design
Above all, the project is well implemented. Keep up the good work!
Marked as helpful
1
Jérémy• 1,020
@jrmydix
Posted
@RioCantre Thank you very much for your feedback!
0