Trying to solve the "QR code component" challenge

Community feedback

• 

  Bright Adigwe•190

  @Femi-BrightPosted over 2 years ago

  Hi! mandresy, Nice attempt. I also deal with the sizing issues, finding the perfect sizing takes much of my time. I should also add this, try to fix the accessibility and HTML issues (you can do that in the View Report section)

  You can adopt using css variables so you don't have to keep repeating those color values. As regards what to learn next. Provided you have a sound knowledge of javascript, you can try React but make more personal research too,

  Marked as helpful

  1

  ---

  

  mandresy andri•90

  @mandresyandriPosted over 2 years ago

  @Femi-Bright Thanks for your advice ! I've done a new challenge this week 🙂 Please do not hesitate to give advice. This day, I'll read documentation about CSS variable.

  1
• 

  Lucas 👾•104,400

  @correlucasPosted over 2 years ago

  Hello Mandresy, congrats for you solution!

  I saw some aspects you can apply to your code, maybe you can use another approach to center the component card in the screen, you can use flexbox to do that instead of using position.

  For example:

  body { display: flex; align-items: center; justify-content: center; height: 100vh; }

  This will align your card to the screen center.

  • Try also to use max-width to have flexible values instead of using width in the card container, this way when your card appear in a smaller screen will be possible that the info inside the container will become smaller when stretch.

  About your question about skills, I'll give you my personal opinion , this mean that I can be wrong. But my idea about a Front-end Development path is start by the start, building a strong base of knowledge in the basics (html, css and js), then learn about git, mobile first, best practices, css naming convention and only then learn frameworks like react, vue, angular. At this moment I'm studying only css and html and I'll start javascript only when I feel confident enought to build any landing page or replicate a big website, but this is only my point of view. Maybe there's other person that started learning more complex things and reach a good level of knowledge.

  Keep it up bro, congratulations for your first challenge.

  Marked as helpful

  0

  ---

  

  mandresy andri•90

  @mandresyandriPosted over 2 years ago

  Hello @correlucas ! 😁 Thank you bro for your advice to align content I'll try to use that for next challenges. About your advice about skills I think you're right I've still got a lot to learn about CSS and I have to learn JS before learning the framework React.

  I've done a new challenge this week please, do not hesitate to leave a comment or advice 😉

  1

  

  Lucas 👾•104,400

  @correlucasPosted over 2 years ago

  @mandresyandri You're welcome Mandresy! I'll look your challenge right now. Happy coding bro! 😁

  0