Design comparison
Solution retrospective
Please review my solution and please give me feedback on how should is improve please.
Community feedback
- @HassiaiPosted over 1 year ago
Replace <h3> and <h4> with <p> to fix the accessibility issue.
To center the main on the page using flexbox, replace the height in the body with min-height: 100vh.
add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
USING FLEXBOX: body{ min-height: 100vh; display: flex; align-items: center; justify-content: center; }
USING GRID: body{ min-height: 100vh; display: grid; place-items: center; }
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
You forgot to add the hover effect to the design
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord