Design comparison
SolutionDesign
Solution retrospective
- Hello all, this is my very first project, and the beginning of my portfolio.
- Please help review and state any corrections necessay.
- I have just noticed the Accessibility issues (lack of landmarks). Point well taken and will correct for subsequent challenges.
Community feedback
- @AgusSaMacPosted over 2 years ago
Hello Trae, congratulations on finishing your first challenge, here's some feedback:
- You have 3 accessibility issues you should deal with them.
- You used a div for the main elements, use instead the <main> tag.
- For your footer, use the <footer> tag instead of a span.
Check https://www.w3schools.com/html/html5_semantic_elements.asp for more info about html semantics.
Best of luck in your coding adventure.
Have a Great Day!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord