Toggle between light and dark mode using Javascript.

Community feedback

• 

  T

  Grace•32,090

  @grace-snowPosted about 4 years ago

  Nice job.

  Two big tips for you:

  • Look into semantic html. This is really important but lacking in your solution at the moment
  • You can simplify the js a lot. I suggest simply toggling a class on a parent element. Everything else to change theme can be handled by the CSS

  BONUS:

  • If you wanted to stretch yourself, try doing this challenge with no js at all, just pure CSS
  • another stretch target would be to use themed variables in your css, so change the variables themselves based off the parent theme class

  Have fun!

  1

  ---

  

  paminus king'ori•210

  @paminus-kingoriPosted about 4 years ago

  Thanks, i'll look into that

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Hey, good work, paminus king'ori! 👍

  Just a tip relating to making your HTML more semantic—make sure you include a heading in each <section> element that you use to clear up those errors in your solution report. 😉

  The rest of your solution looks pretty good and your grid responds well! 🙌

  Keep coding (and happy coding, too)! 😁

  0

  ---

  

  paminus king'ori•210

  @paminus-kingoriPosted about 4 years ago

  Thanks, I really appreciate. I'll look into that. Happy coding too😅

  0