Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

toggle

kamiya nakamiโ€ข 270

@kamiya-nakami

Desktop design screenshot for the FAQ accordion card coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Abdul Khaliq ๐Ÿš€โ€ข 72,580

@0xabdulkhaliq

Posted

Hello there ๐Ÿ‘‹. Congratulations on successfully completing the challenge! ๐ŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

ACCORDION ๐Ÿ”ด :

  • The best way to go with creating the accordion elements in this challenge would be with the details and summary elements (or perhaps a combination of buttons and other elements).
  • They are already fairly accessible and provided a clean, semantic way to create accordion elements. I see you have used the h1, div & p elements for the accordions, but those are not interactive or accessible by keyboard, so not all users will be able to open the accordions to see the content inside.
  • MDN's reference is a great place to start learning about the details and summary elements if you are interested.
  • If you have any questions or need further clarification, you can always check out my submission for this challenge and/or feel free to reach out to me.

.

I hope you find this helpful ๐Ÿ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

kamiya nakamiโ€ข 270

@kamiya-nakami

Posted

@0xAbdulKhalid I appreciate your recommendations, thank you. I'll sign your suggestions for my Accordia projects. I'll do it better next time

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord