Design comparison
Community feedback
- @Alucard2169Posted about 2 years ago
Hi, Great job on the design,
next you should try to make it interactive and functional, as it will give you tons to learn on the way.
Here is how you can fix your HTML and Accessibility errors:
-
you should always change heading size by one, for example ( a page must have a H1 heading (very important), after that you should decrease the size by one like h2 > h3 > h4 ...., don't just jump to h3 or h4 );
-
Input element must have a label all times, here is how you can do that
<label for="{your input's ID}"> *some_text* </label> <input id="{your input's ID}" >
hope that helps
Marked as helpful1@msabdalaalPosted about 2 years ago@Alucard2169 Hi, thx for the great feedback,
the thing is the App is already interactive and functional, I guess there was a problem with the js file which is fixed right now, **please try using the app once more now,
and I fixed the Accessibility errors as you told me, thx again
1@Alucard2169Posted about 2 years ago@msabdalaal great work, i see that you are storing the whole task element in you local storage, so when user re opens the page, the whole component has to re-render, try to just store the task inside the local storage and then access it in the form of an array, so when user reloads the page, you can map over the array and display the tasks dynamically.
Hope this helps.
GOOD LUCK!
Marked as helpful1@msabdalaalPosted about 2 years ago@Alucard2169 , Hi, thx for the review one more time, just finished doing as you suggested, you can take a look now, but make sure you delete the previous local storages before you try it out.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord